Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (Support Innoviz Two) #66

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

feat: (Support Innoviz Two) #66

wants to merge 17 commits into from

Conversation

moshecikk
Copy link

PR Type

  • New Feature

Related Links

MapIV/transport_drivers#6

Description

This PR adds support for InnovizTwo sensors.

Review Procedure

Remarks

This change depends on the linked PR in the transport_drivers project.
Currently the dependency is on the fork where the change was implemented. Once this change is merged, the dependency can be moved back to the boost branch of the MapIV transport_drivers project.

Pre-Review Checklist for the PR Author

  • Assign PR to reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Moshe Cikk and others added 17 commits August 20, 2023 16:32
@moshecikk moshecikk changed the title Support innoviz two feat: Support innoviz two Sep 3, 2023
@moshecikk moshecikk changed the title feat: Support innoviz two feat(innoviz_driver): Support innoviz two Sep 3, 2023
@moshecikk moshecikk changed the title feat(innoviz_driver): Support innoviz two feat: (Support Innoviz Two) Sep 3, 2023
@drwnz drwnz requested review from amc-nu and drwnz September 6, 2023 09:20
@codecov-commenter
Copy link

Codecov Report

Attention: 363 lines in your changes are missing coverage. Please review.

Comparison is base (e0d05a7) 13.35% compared to head (307fee8) 16.57%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   13.35%   16.57%   +3.21%     
==========================================
  Files         111       66      -45     
  Lines       10989     9152    -1837     
  Branches     1725     1846     +121     
==========================================
+ Hits         1468     1517      +49     
+ Misses       8345     6349    -1996     
- Partials     1176     1286     +110
Flag Coverage Δ
differential 16.57% <24.37%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ula_common/include/nebula_common/nebula_common.hpp 0.00% <ø> (ø)
...ers_innoviz/decoders/innoviz_two_raven_decoder.hpp 100.00% <100.00%> (ø)
...ers_innoviz/decoders/innoviz_two_raven_decoder.cpp 100.00% <100.00%> (ø)
...decoders_innoviz/decoders/innoviz_scan_decoder.hpp 0.00% <0.00%> (ø)
...rs_innoviz/decoders/innoviz_two_condor_decoder.hpp 0.00% <0.00%> (ø)
...rs_innoviz/decoders/innoviz_two_condor_decoder.cpp 0.00% <0.00%> (ø)
...ts/innoviz/innoviz_ros_decoder_test_main_raven.cpp 35.00% <35.00%> (ø)
...ers/src/nebula_decoders_innoviz/innoviz_driver.cpp 42.30% <42.30%> (ø)
...decoders_innoviz/decoders/innoviz_scan_decoder.cpp 73.91% <73.91%> (ø)
...ula_innoviz_hw_interfaces/innoviz_hw_interface.cpp 0.00% <0.00%> (ø)
... and 3 more

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amc-nu amc-nu Awaiting requested review from amc-nu

@drwnz drwnz Awaiting requested review from drwnz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moshecikk @codecov-commenter